Re: psql patch

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql patch
Date: 2006-09-13 16:19:11
Message-ID: 45082F7F.6050107@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane a ecrit le 13/09/2006 18:05:
> Guillaume Lelarge <guillaume(at)lelarge(dot)info> writes:
>> diff -r1.89 print.c
>> 853c853
>> < snprintf(record_str, 64, "* Record %lu", record++);
>> ---
>>> snprintf(record_str, 64, _("* Record %lu"), record++);
>> 855c855
>> < snprintf(record_str, 64, "[ RECORD %lu ]", record++);
>> ---
>>> snprintf(record_str, 64, _("[ RECORD %lu ]"), record++);
>
> Hm, these strings were never localizable in previous versions; if we
> make them so, do we risk breaking any code that examines psql output?
>

Don't know but I always thought tools shoudn't rely on strings output.

> What about the equivalent headers in the other output formats?
>

Which one ? can you give me an example ?

Regards.

--
Guillaume.

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-09-13 16:28:47 Re: contrib uninstall scripts need some love
Previous Message Tom Lane 2006-09-13 16:05:51 Re: psql patch