| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Weird test mixup |
| Date: | 2024-03-15 11:09:30 |
| Message-ID: | 44f5bf13-b46e-4b87-84de-2ac70fddbda0@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15/03/2024 01:13, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> Or we could just disable runningcheck because of the concurrency
>> requirement in this test. The test would still be able to run, just
>> less times.
>
> No, actually we *must* mark all these tests NO_INSTALLCHECK if we
> stick with the current definition of injection points. The point
> of installcheck mode is that the tests are supposed to be safe to
> run in a live installation. Side-effects occurring in other
> databases are completely not OK.
I committed a patch to do that, to put out the fire.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2024-03-15 11:20:10 | Re: MERGE ... RETURNING |
| Previous Message | Jelte Fennema-Nio | 2024-03-15 11:09:10 | Re: Possibility to disable `ALTER SYSTEM` |