Re: Values list-of-targetlists patch for comments (was Re: [PATCHES]

Bruce Momjian wrote:
> Should we wait for someone to actually ask for this before adding it
> to the TODO list?

Probably worth adding it to the TODO list so it doen't get lost.

> Does it cause a crash now?

Nope:

regression=# create table log(f1 int, f2 int, tag text);
CREATE TABLE
regression=# insert into src values(1,2);
INSERT 0 1
regression=# create rule r2 as on update to src do insert into log
values(old.*, 'old'), (new.*, 'new');
ERROR: VALUES must not contain OLD or NEW references

Joe