Re: [PATCHES] Generic Monitoring Framework with DTrace patch

Peter Eisentraut wrote:

>Robert Lor wrote:
>
>
>>The user needs to have the flexibility to build a 32 bit PG binary
>>even when he run the 64 bit kernel. If I understand you correctly,
>>your suggestion will not allow a 32 bit binary to be built on a 64
>>bit OS.
>>
>>
>
>I'm not sure about the context. How do you control whether the
>PostgreSQL binaries you are about to build end up 32 bit or 64 bit?
>Presumably there is some default, and you switch it using CFLAGS or
>LDFLAGS.
>
To build 64 bit binary, I use the following flag depending on the
compiler. Without -m64 or -xtarget=native64, it defaults to 32 bit.
CC='gcc -m64'
CC='/<path_to_sun_compiler>/cc -xtarget=native64'

> Then it would make sense to let dtrace be controled by
>DTRACE_FLAGS or some such. But what does dtrace do if no flag at all
>is given?
>
>
We want to be able to set DTRACEFLAGS to 32 or 64 (e.g. DTRACEFLAGS='64').

If DTRACEFLAGS is not set, can we provide a default value to 32?
Otherwise, the compile will fail. It's also possible that the CC and
DTRACEFLAGS are in conflict, and in that case the compile will also
fail, which is probably okay.

Regards,
-Robert