| From: | Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Patch for - Change LIMIT/OFFSET to use int8 |
| Date: | 2006-07-11 19:36:13 |
| Message-ID: | 44B3FDAD.1030102@sun.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
I have made the changes appropriately. The regression tests passed.
Since I do not have enough resources, I could not test for a large number.
It works for a small table. If anybody tests for int8 value, it is
appreciated.
Also, it gives the following error msg, when the input exceeds the int8
limit.
ERROR: bigint out of range
I attach the patch. Pl. check it.
Thanks
Dhanaraj
Tom Lane wrote:
>Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM> writes:
>
>
>>I attach the patch for the following TODO item.
>> SQL COMMAND
>> * Change LIMIT/OFFSET to use int8
>>
>>
>
>This can't possibly be correct. It doesn't even change the field types
>in struct LimitState, for example. You've missed half a dozen places
>in the planner that would need work, too.
>
> regards, tom lane
>
>---------------------------(end of broadcast)---------------------------
>TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| limit-offset_patch.txt | text/plain | 12.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Kreen | 2006-07-11 19:57:33 | [patch 0/9] annual pgcrypto update |
| Previous Message | Simon Riggs | 2006-07-11 16:55:46 | Restartable Recovery |