From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Neil Conway <neilc(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Do a pass of code review for the |
Date: | 2006-07-02 18:50:18 |
Message-ID: | 44A8156A.3050101@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
>>Thanks, that is what was needed. The author obviously took the patch as
>>far as he could, and we needed to adjust his XXX areas, rather than not
>>apply the patch and have the code drifting.
>>
>>
>
>Hmm, is this how we should do things? I mean, should I finish the
>autovacuum parts of my relminxid patch, apply it, and then hope for
>someone to fix the mistaeks? And if we don't see any failure in the
>buildfarm, assume that all is well?
>
>To me this is really the easiest way, but I have a hard time convincing
>myself that I want to have it easy but break things in a way that nobody
>notices. The other day when I typoed a commit to the 8.1 branch I was
>all red in the face. I wonder what will happen if someone points to me
>or Greg as causing major breakage somewhere, just because the patch was
>applied in a hurry without careful review.
>
>
>
I am guilty of a similar recent sin that Tom caught. But, like you, I am
opposed to lessening the stability in the code base, which is something
we should be proud of and guard carefully.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-07-02 19:51:39 | Re: [COMMITTERS] pgsql: Do a pass of code review for the |
Previous Message | Alvaro Herrera | 2006-07-02 17:18:33 | Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeremy Drake | 2006-07-02 19:12:12 | Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) |
Previous Message | Simon Riggs | 2006-07-02 17:36:30 | Re: note about syntax for fillfactor patch |