| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Move pg_attribute.attcompression to earlier in struct for reduced size? |
| Date: | 2021-06-04 22:51:00 |
| Message-ID: | 449921.1622847060@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> It seems to me that most of the overhead is the function call for
> toast_get_compression_id(), so we should get rid of that.
Nice result. I'm willing to live with 1.5% slowdown ... IME that's
usually below the noise threshold anyway.
> Now, while this patch does seem to work correctly, it raises a number of
> weird cpluspluscheck warnings, which I think are attributable to the
> new macro definitions. I didn't look into it closely, but I suppose it
> should be fixable given sufficient effort:
Didn't test, but the first one is certainly fixable by adding a cast,
and I guess the others might be as well.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume de Rorthais | 2021-06-04 22:53:44 | Re: [Proposal] Add accumulated statistics for wait event |
| Previous Message | Bruce Momjian | 2021-06-04 22:47:16 | Re: PG 14 release notes, first draft |