Re: PostgreSQL 11 beta1 on AIX 7.2 : 2 failures in 32bit mode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "REIX, Tony" <tony(dot)reix(at)atos(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "APEKE, SENA (ext)" <sena(dot)apeke(dot)external(at)atos(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "Anthony Bykov" <a(dot)bykov(at)postgrespro(dot)ru>, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: PostgreSQL 11 beta1 on AIX 7.2 : 2 failures in 32bit mode
Date: 2018-05-31 16:47:53
Message-ID: 4498.1527785273@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"REIX, Tony" <tony(dot)reix(at)atos(dot)net> writes:
> v11beta1 brings new json files. Either these files reveal some issue on AIX 32bit or they contain code that is not compatible with AIX environment and some change should be applied...

One thing I notice is that jsonb_plperl.c starts with

#include "postgres.h"

#include "plpython.h"
#include "plpy_elog.h"
#include "plpy_typeio.h"
#include "utils/jsonb.h"
#include "utils/fmgrprotos.h"
#include "utils/numeric.h"

which does not follow the comment in plpython.h:

* Include order should be: postgres.h, other postgres headers, plpython.h,
* other plpython headers

So it seems this should be

#include "postgres.h"

#include "utils/jsonb.h"
#include "utils/fmgrprotos.h"
#include "utils/numeric.h"

#include "plpython.h"
#include "plpy_elog.h"
#include "plpy_typeio.h"

However, I don't see how that relates to _LARGE_FILES. As long as
postgres.h is first, which it is, seems like that should work.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2018-05-31 17:31:24 Re: pg_replication_slot_advance to return NULL instead of 0/0 if slot not advanced
Previous Message REIX, Tony 2018-05-31 16:21:39 RE:PostgreSQL 11 beta1 on AIX 7.2 : 2 failures in 32bit mode