| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Mi Tar <mmitar(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: port of INSTALL file generation to XSLT |
| Date: | 2019-01-11 15:15:20 |
| Message-ID: | 4466.1547219720@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 09/01/2019 10:05, Mi Tar wrote:
>> I tested this. Patch applied cleanly and INSTALL file was produced. Formatting looks differently from before, but I think that it looks better. We lost central alignment of some headings, but many code/command snippets are now better/correctly indented. So I think this is overall better.
> Committed with a fix for that, thanks.
So this has got a couple of problems:
1. No pandoc on borka, where we build tarballs:
pgsql(at)borka:~$ which pandoc
pgsql(at)borka:~$
Probably we can get the sysadmin team to fix that, but ...
2. If there's no pandoc, this coding silently produces a zero-size
INSTALL file. I do not find that acceptable.
pgsql(at)borka:~$ mk-release 96b8b8b6f9d8de4af01a77797273ad88c7a8e32e
...
Commit 96b8b8b6f9d8de4af01a77797273ad88c7a8e32e packaged as postgresql-12devel.tar.bz2 postgresql-12devel.tar.bz2.md5 postgresql-12devel.tar.bz2.sha256 postgresql-12devel.tar.gz postgresql-12devel.tar.gz.md5 postgresql-12devel.tar.gz.sha256
pgsql(at)borka:~$ tar tvfj output/postgresql-12devel.tar.bz2 | grep INSTALL
-rw-r--r-- pgsql/pgsql 0 2019-01-11 15:09 postgresql-12devel/INSTALL
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-01-11 15:22:11 | Re: [HACKERS] generated columns |
| Previous Message | Tom Lane | 2019-01-11 14:48:02 | Re: Three animals fail test-decoding-check on REL_10_STABLE |