Re: [HACKERS] Question on win32 semaphore simulation

From: "Peter Brant" <Peter(dot)Brant(at)wicourts(dot)gov>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Question on win32 semaphore simulation
Date: 2006-05-12 18:00:29
Message-ID: 446486ED020000BE0000390A@gwmta.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Ah, sorry for the late response (and for any confusion), but the only
thing I tested was Qingqing's rewritten semaphore implementation. I
didn't test the proposed bug fixes to the existing semaphore
implementation.

We've never been able reproduce (or even trigger) the original "sem_ctl
failed" error in a testing environment so it would be hard to say if the
changes to win32/sema.c have an impact on it or not. On the other hand,
win32_sema.c seems to solve the pgbench lockups reported earlier by Jim
N. and it successfully completes a reasonably brutal stress test with
real world data and real world queries (which at least is a good
indication that it basically works).

Pete

>>> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> 05/11/06 4:08 am >>>
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> Well we did have a bug report by Peter Brant, and a test by him
with the
> >> patch that fixes it, so it seems it should be applied. The URLs
I
> >> posted had that information.

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-05-12 18:07:38 Re: [HACKERS] Question on win32 semaphore simulation
Previous Message Matteo Beccati 2006-05-12 13:56:03 Re: [HACKERS] Enhanced containment selectivity function