Re: [BUGS] BUG #2401: spinlocks not available on amd64

From: Kris Jurka <books(at)ejurka(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64
Date: 2006-04-28 04:25:48
Message-ID: 4451994C.8020001@ejurka.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Bruce Momjian wrote:
> Great, changes attached and applied. I removed the solaris_i386 and
> solaris_x86_64.s files and made just one solaris_x86.s. I updated the
> build system to use the new file, updated the macros, and added some
> documentation on the approach. Thanks.
>
> Would you test current CVS to make sure it still works properly? Thanks.
>

The patch adds an extra else in src/template/solaris that means the
assembly file is not properly picked up.

Also the claim that Sun's cc understands C preprocessor doesn't hold
true for me:

/usr/local/SUNWspro/bin/cc -Xa -v -DSUNOS4_CC -g -c tas.s
Assembler: tas.s
"tas.s", line 9 : Illegal mnemonic
"tas.s", line 9 : Syntax error
"tas.s", line 9 : Illegal mnemonic
"tas.s", line 9 : Illegal mnemonic

This is with cc -V
cc: Sun WorkShop 6 update 2 C 5.3 Patch 111680-09 2003/05/18

Attachment Content-Type Size
solaris-pick-tas.patch text/plain 964 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Sidar Lopez Cruz 2006-04-28 04:27:27 BUG #2412: Foreing key accept nulls
Previous Message Bruce Momjian 2006-04-28 03:43:28 Re: [BUGS] BUG #2401: spinlocks not available on amd64

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-04-28 04:34:05 Re: [BUGS] BUG #2401: spinlocks not available on amd64
Previous Message Bruce Momjian 2006-04-28 03:43:28 Re: [BUGS] BUG #2401: spinlocks not available on amd64