Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam
Date: 2016-03-30 01:13:36
Message-ID: 4445.1459300416@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Wed, Mar 30, 2016 at 6:09 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Allow to_timestamp(float8) to convert float infinity to timestamp infinity.

> Some of the tests introduced are making MSVC unhappy, because they
> depend on the three-digit behavior that Windows is using, leading to
> those failures:

Ah, I was wondering about that. The patch as-submitted used "%lf" which
seemed even less likely to be portable, but evidently %g isn't that much
better.

> If the those tests are kept, an alternate output file is necessary (I
> can send a patch if needed, I see the failure locally as well).

I'm inclined to just drop the out-of-range test cases. They're not that
useful IMO, and alternate expected-files are a real PITA for maintenance.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2016-03-30 01:22:20 Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam
Previous Message Michael Paquier 2016-03-30 00:19:58 Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-03-30 01:22:20 Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam
Previous Message Tom Lane 2016-03-30 01:09:04 Re: Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used