Re: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Itamar Gafni <itamar(dot)gafni(at)imperva(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags
Date: 2021-08-12 13:32:27
Message-ID: 44436120-2AC2-487C-A807-F7C0EE4963AD@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 12 Aug 2021, at 12:00, Itamar Gafni <itamar(dot)gafni(at)imperva(dot)com> wrote:

> Copying it means there are two BIO_METHOD objects with the same type (ortig
> socket and its copy) but it's unclear if that's an issue.

Reading code there doesn't seem to be a concensus really, Apple is doing it in
the Swift TLS code but otheres aren't. Considering there's been no complaints
on this and OpenSSL < 1.1.0 is EOL I say we leave it for now.

Barring objections I will go ahead with your proposed patch on HEAD and
backpatch it all the way, once I've done more testing on it.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-08-12 13:33:06 Re: call popcount32/64 directly on non-x86 platforms
Previous Message David Rowley 2021-08-12 13:28:32 Re: call popcount32/64 directly on non-x86 platforms