| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | <pgsql-patches(at)postgresql(dot)org>, "Magnus Hagander" <mha(at)sollentuna(dot)net>, "Peter Brant" <Peter(dot)Brant(at)wicourts(dot)gov> |
| Subject: | Re: pgstat: remove delayed destroy / pipe: socket |
| Date: | 2006-04-06 17:46:23 |
| Message-ID: | 44350D9F.EE98.0025.0@wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
>>> On Thu, Apr 6, 2006 at 12:26 pm, in message
<6BCB9D8A16AC4241919521715F4D8BCEA0F8DF(at)algol(dot)sollentuna(dot)se>, "Magnus
Hagander"
<mha(at)sollentuna(dot)net> wrote:
> And finally, the error handling looks a bit off? We specifically
*don't*
> want it to log an error for the WSAECONNRESET state - it's a normal
> state. Or am I reading the patch wrong?
It looks to me like error is never referenced except when ret ==
SOCKET_ERROR. When ret == SOCKET_ERROR and error == WSAEWOULDBLOCK it
loops back without generating an error message.
-Kevin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Brant | 2006-04-06 17:58:46 | Re: pgstat: remove delayed destroy / pipe: socket |
| Previous Message | Magnus Hagander | 2006-04-06 17:43:17 | Re: pgstat: remove delayed destroy / pipe: socket error fix |