| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Generate pg_stat_get_xact*() functions with Macros |
| Date: | 2023-03-27 06:54:13 |
| Message-ID: | 442ba19a-6e8a-3fe3-d404-e9101dfbfcbb@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/27/23 8:40 AM, Michael Paquier wrote:
> On Mon, Mar 27, 2023 at 07:45:26AM +0200, Drouvot, Bertrand wrote:
>> Thanks! LGTM, but what about also taking care of pg_stat_get_xact_function_total_time()
>> and pg_stat_get_xact_function_self_time() while at it?
>
> With a macro that uses INSTR_TIME_GET_MILLISEC() to cope with
> instr_time? Why not, that's one duplication less.
Yes, something like V1 up-thread was doing. I think it can be added with your current proposal.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-03-27 06:56:53 | Re: PGdoc: add missing ID attribute to create_subscription.sgml |
| Previous Message | Michael Paquier | 2023-03-27 06:40:31 | Re: Generate pg_stat_get_xact*() functions with Macros |