Re: pg_get_object_address() doesn't support composites

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_get_object_address() doesn't support composites
Date: 2017-02-18 22:26:34
Message-ID: 4429fd84-0838-7582-09a2-31b6c6ac74dc@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/17/17 9:53 PM, Alvaro Herrera wrote:
> Jim Nasby wrote:
>> See below. ISTM that pg_get_object_address should support everything
>> pg_identify_object_as_address can output, no?
>>
>> I'm guessing the answer here is to have pg_identify_object_as_address
>> complain if you ask it for something that's not mapable.
> Yes, I think we should just reject the case in
> pg_identify_object_as_address.

Attached patch does that, and tests for it. Note that there were some
unsupported types that were not being tested before. I've added a
comment requesting people update the test if they add more types.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)

Attachment Content-Type Size
object_address_unsuported.patch text/plain 6.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-02-18 22:27:42 Re: [COMMITTERS] pgsql: Add new function dsa_allocate0.
Previous Message Tom Lane 2017-02-18 22:18:44 Re: Keeping pg_recvlogical's "feTimestamp" separate from TimestampTz