Re: FTI contrib

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FTI contrib
Date: 2001-09-06 21:31:41
Message-ID: 4422.999811901@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Has this been addressed?

IIRC, I looked at the patch and decided it was okay.

regards, tom lane

>> "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> The latest patch we submitted to the fulltextindex module improved lots of
> things but something we could not get to work was the apparently correct use
> of the PG_GETARG* macros, etc.
>>
> Whenever we used these macros, we always got 0 or NULL as our values. So,
> we reverted to the trigger->tgargs array.
>>
>> Trigger functions don't get their arguments the normal way. The GETARG
>> macros don't know anything about trigger arguments... so the original
>> code was correct as it was. I haven't had time to look at your patch,
>> but maybe I should go do that.
>>
>> regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message mlw 2001-09-06 23:28:03 Great Bridge
Previous Message Bruce Momjian 2001-09-06 20:47:06 Re: FTI contrib