From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: how to run encoding-dependent tests by default |
Date: | 2019-07-05 11:33:17 |
Message-ID: | 440c67f5-778b-8b80-0915-24d5c99e68a6@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-06-23 21:44, Peter Eisentraut wrote:
> On 2019-06-17 18:39, Andres Freund wrote:
>> Basically something like:
>>
>> \gset SELECT my_encodings_are_compatible() AS compatible
>> \if :compatible
>> test;
>> contents;
>> \endif
>
> Cool, that works out quite well. See attached patch. I flipped the
> logic around to make it \quit if not compatible. That way the
> alternative expected file is shorter and doesn't need to be updated all
> the time. But it gets the job done either way.
Small patch update: The collate.linux.utf8 test also needs to check in a
similar manner that all the locales it is using are installed. This
should get the cfbot run passing.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Run-UTF8-requiring-collation-tests-by-default.patch | text/plain | 6.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jose Luis Tallon | 2019-07-05 11:35:58 | Re: [PATCH] Implement uuid_version() |
Previous Message | Pavel Stehule | 2019-07-05 11:30:52 | Re: range_agg |