From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Dubious usage of TYPCATEGORY_STRING |
Date: | 2021-12-09 15:27:31 |
Message-ID: | 43d84b1f-0baf-f458-b75a-f16f021900c4@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 07.12.21 21:24, Tom Lane wrote:
> I wrote:
>> Peter Eisentraut<peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>>> Could we add explicit casts (like polcmd::text) here? Or would it break
>>> too much?
>> I assumed it'd break too much to consider doing that. But I suppose
>> that since a typcategory change would be initdb-forcing anyway, maybe
>> it's not out of the question. I'll investigate and see exactly how
>> many places would need an explicit cast.
> Um, I definitely gave up too easily there. The one usage in \dp
> seems to be the*only* thing that breaks in describe.c, and pg_dump
> doesn't need any changes so far as check-world reveals. So let's
> just move "char" to another category, as attached.
Looks good to me.
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2021-12-09 15:41:21 | Re: Non-superuser subscription owners |
Previous Message | Peter Eisentraut | 2021-12-09 15:24:23 | Re: Post-CVE Wishlist |