| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | clean up test_rls_hooks module |
| Date: | 2022-03-23 13:31:04 |
| Message-ID: | 43bcaaab-077e-cebe-35be-3cd7f2633449@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Over at [1] Mark Dilger got led astray because he used
src/test/modules/test_rls_hooks as a template for his new test module.
It looks like that module was created with some over eager copying of
another test module, but it has a couple of things wrong with it.
. it isn't an extension, so the Makefile shouldn't have an EXTENSION
entry, and there shouldn't be a .control file
. it doesn't need to be preloaded so there is no requirement for a
special config, nor for corresponding REGRESS_OPTS and NO_INSTALLCHECK
lines in the Makefile.
Here's a patch to fix those things.
cheers
andrew
[1]
https://postgr.es/m/47F87A0E-C0E5-43A6-89F6-D403F2B45175@enterprisedb.com
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-fix-test_rls_hooks.patch | text/x-patch | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-03-23 13:33:34 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Previous Message | Robert Haas | 2022-03-23 13:19:42 | Re: refactoring basebackup.c (zstd workers) |