Re: Patch for ALTER TABLE / TYPE

From: NAKANO Yoshihisa <nakano(dot)yosihisa(at)jp(dot)fujitsu(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for ALTER TABLE / TYPE
Date: 2006-01-30 01:03:26
Message-ID: 43DD65DE.2050603@jp.fujitsu.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> After looking at the test case a bit, I have an alternate approach:
> constraints on the column will have DEPENDENCY_AUTO type, while
> constraints using the column will have DEPENDENCY_NORMAL type.
> Therefore, if we drop the NORMAL ones before the AUTO ones, that
> should be enough to fix it. This doesn't require much extra code,
> or any extra catalog searches, since the pg_depend record is already
> available in ATExecAlterColumnType where we need to decide whether
> to stick the item on the front or back of the list.

O.K. It seems nicer than my solution.

Please find the patch attached. I fixed the patch to decide the order
of the list by deptype of the pg_depend record.

Regards,
Nakano

Attachment Content-Type Size
tablecmds.c.patch text/plain 2.5 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Woodward 2006-01-30 02:27:19 Re: Want to add to contrib.... xmldbx
Previous Message David Fetter 2006-01-30 01:03:02 Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ... TO