plperl header fix and rationalisation

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: plperl header fix and rationalisation
Date: 2006-01-08 14:37:51
Message-ID: 43C123BF.6020205@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


The perl headers on Win32 try to hijack stdio and lots of other stuff
(like getenv). This is annoying, as it generates lots of warnings, and
probably dangerous as well. To inhibit that we would need to set a flag
before the header inclusion, thus:

#ifdef WIN32
#define WIN32IO_IS_STDIO
#endif

It turns out that we would need to put that in three places (plperl.c,
SPI.xs and spi_internal.h). I propose to rationalise header file use
somewhat, by creating plperl.h, and removing spi_internal.h. plperl.h
will do the above, include all the necessary perl header files, and
define the spi_internal routines.

Comments?

cheers

andrew

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Buttafuoco 2006-01-08 14:52:19 Fw: Is anyone interested in getting PostgreSQL working on mips[el]?
Previous Message Magnus Hagander 2006-01-08 14:05:15 Re: stat /etc/localtime 38000 times on startup?