| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, ntufar(at)gmail(dot)com, devrim(at)kivi(dot)com(dot)tr, mha(at)sollentuna(dot)net, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] snprintf() argument reordering not working |
| Date: | 2005-12-05 17:53:49 |
| Message-ID: | 43947EAD.2010601@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
>>Was the last patch you sent in ready for application, or are you still
>>fooling with it?
>>
>>
>
>He is still working on it. It did not handle all *printf functions, as
>he mentioned, and he might have other changes.
>
>
>
Yeah.
The good news: the new pg_*printf does the right thing for the %m$
parameters in the Turkish locale.
The bad news: if we aren't compiling with NLS enabled, having those
entries in exports.txt makes the libpq build blow up. So either we need
to use pg_*printf unconditionally on Windows, or we need a little
Makefile + sed magic to strip those entries out of exports.txt when it
is used, if we're not doing NLS, or something of that kind.
Question: do the entries in exports.txt have to be numbered
consecutively, or just uniquely?
With luck I can probably wrap this up today for the 8.1 stable branch -
it would be nice if the new release actually did NLS right.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zoltan Boszormenyi | 2005-12-05 18:03:41 | Re: SERIAL type feature request |
| Previous Message | Bruce Momjian | 2005-12-05 17:38:17 | Reduce NUMERIC size by 2 bytes, reduce max length to 508 digits |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-12-05 18:18:56 | Re: [PATCHES] snprintf() argument reordering not working |
| Previous Message | Bruce Momjian | 2005-12-05 17:38:17 | Reduce NUMERIC size by 2 bytes, reduce max length to 508 digits |