I noticed that if you use "initdb -S", the code does its thing and
exits without ever calling get_restricted_token(). It doesn't get
to get_id() where the no-superuser check is, either. Is this OK,
or should we reorder the operations so that fsyncing is done with
the usual restricted privileges?
You could argue that it's harmless to let root do a bunch of fsyncs,
and that's probably true, but on the other hand this doesn't meet
our usual expectations that no significant PG code runs as root.
Thoughts?
regards, tom lane