| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Smith, Peter" <peters(at)fast(dot)au(dot)fujitsu(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: Command statistics system (cmdstats) |
| Date: | 2020-09-17 15:03:55 |
| Message-ID: | 437B24FD-8741-44B5-9BA7-6FAF1DD11FC3@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 17, 2020, at 5:40 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2020-Sep-17, Michael Paquier wrote:
>
>> On Wed, Jun 10, 2020 at 01:45:02PM -0400, Robert Haas wrote:
>>> My spidey sense is tingling here, telling me that we need some actual
>>> benchmarking.
>>
>> This patch has not received any replies after this comment for three
>> months, so I am marking it as returned with feedback. I agree that
>> this should be benchmarked carefully.
Yes, I have prioritized a couple other patches over this one, with benchmarking this patch lower down my priority list. Thank you, Michael, for the reminder!
>
> It seems fine to mark the patch as RwF at the end of commitfest, but
> that's two weeks away. I don't understand what is accomplished by doing
> it ahead of time, other than alienating the patch authors.
Thanks, Álvaro! I do not feel alienated, and I hope Haribabu Kommi does not either.
Haribabu, do you have an opinion on which of the two patches should proceed? I don't recall seeing a response from you about whether you liked what I did with your patch. Perhaps you were waiting on the benchmarking results?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josef Šimánek | 2020-09-17 15:08:46 | Re: [PATCH] Initial progress reporting for COPY command |
| Previous Message | Robert Haas | 2020-09-17 14:40:09 | Re: fixing old_snapshot_threshold's time->xid mapping |