Re: latest commit breaks tsearch2

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: latest commit breaks tsearch2
Date: 2005-11-14 10:08:16
Message-ID: 43786210.8030908@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> query_gist.c: In function `sizebitvec':
> query_gist.c:203: warning: control reaches end of non-void function
Fixed

>
> Looking at the code, gcc is right to complain --- if this is working for
> you it's only accidental.

It works because index tree was correct but was very far from optimal.

> I don't much care for the hard-wired
> assumption about the size of TPQTGist either ...

typedef uint64 TPQTGist;

What is your doubt? You suggest to use sizeof(TPQTGist)*BIT_PER_BYTE?

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-11-14 14:02:57 Re: latest commit breaks tsearch2
Previous Message Teodor Sigaev 2005-11-14 09:59:13 pgsql: fix returning value