Re: BUG #16613: Built in suppress_redundant_updates_trigger() trigger not supressing redundant updates

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: stephane(dot)desnault(at)gmail(dot)com
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16613: Built in suppress_redundant_updates_trigger() trigger not supressing redundant updates
Date: 2020-09-09 17:38:50
Message-ID: 43786.1599673130@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> The built-in suppress_redundant_updates_trigger() trigger is not supressing
> redundant updates after an ALTER TABLE ... ADD COLUMN...

This doesn't seem like a bug. The trigger code is looking for bitwise
equality between new tuple and old tuple, which it won't find because
the new tuple will have a larger number-of-attributes field; not to
mention a possibly-wider nulls bitmap.

Sure, we could complicate the trigger to try to understand such cases,
but that would likely make things net slower in most applications.
The hard part of having such a trigger is that it's pure overhead
for real updates, so that overhead has to be minimized.

Possibly the documentation could be clarified. What it says now is
"prevent any update that does not actually change the data in the
row from taking place", which is pretty vague about what the criteria
really are. Not sure about better wording though.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Stephane Desnault 2020-09-09 18:05:11 Re: BUG #16613: Built in suppress_redundant_updates_trigger() trigger not supressing redundant updates
Previous Message PG Bug reporting form 2020-09-09 16:25:00 BUG #16613: Built in suppress_redundant_updates_trigger() trigger not supressing redundant updates