| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PQunescapeBytea code |
| Date: | 2003-10-31 17:21:52 |
| Message-ID: | 4361.1067620912@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Jeroen T. Vermeulen" <jtv(at)xs4all(dot)nl> writes:
> This code completely ignores any other usage of the backslash in the
> escaped string, generating no output for unknown escape sequences. Is
> that the desired behaviour?
As Adam pointed out, the code does do the right thing for other
backslash sequences; it just processes the character on the following
loop iteration. I'll add a comment to explain this.
I see another issue here, which is that for a zero-length input string
we will do malloc(0) and realloc(foo, 0), neither of which are very
portable. Will fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Wieck | 2003-10-31 17:22:50 | Re: Experimental patch for inter-page delay in VACUUM |
| Previous Message | Tom Lane | 2003-10-31 17:05:06 | Re: Experimental patch for inter-page delay in VACUUM |