Adding missing object access hook invocations

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Adding missing object access hook invocations
Date: 2020-03-16 23:03:51
Message-ID: 435CD295-F409-44E0-91EC-DF32C7AFCD76@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hackers,

While working on object access hooks, I noticed several locations where I would expect the hook to be invoked, but no actual invocation. I think this just barely qualifies as a bug. It's debatable because whether it is a bug depends on the user's expectations and whether not invoking the hook in these cases is defensible. Does anybody have any recollection of an intentional choice not to invoke in these locations?

Patch attached.

Attachment Content-Type Size
v1-0001-Adding-missing-Object-Access-hook-invocations.patch application/octet-stream 3.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message imai.yoshikazu@fujitsu.com 2020-03-17 00:07:30 RE: Planning counters in pg_stat_statements (using pgss_store)
Previous Message Mark Dilger 2020-03-16 22:59:06 Adding test coverage for ALTER SEQUENCE .. SET SCHEMA