Re: pgsql: Rework the pg_statistic_ext catalog

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Subject: Re: pgsql: Rework the pg_statistic_ext catalog
Date: 2019-06-16 15:16:04
Message-ID: 4352.1560698164@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>> OK, it seems the buildfarm is getting green again. I'm not sure why I'm
>> seeing the failure in 011_crash_recovery.pl, while the buildfarm does
>> not. Perhaps my environment is borked in some way? Not sure.

> I see that Coelho's two bleeding-edge-clang animals are reporting that
> failure too. Normally I'd just ignore those two; they break pretty
> regularly. Maybe you're using an almost-bleeding-edge clang?

Oh --- I managed to reproduce that failure locally on RHEL6 (nothing
bleeding-edge anywhere), but it went away after make-clean-and-rebuild.
I'm suspicious that the underlying cause was failure to recompile
something that knows the value of CATALOG_VERSION_NO.

This theory is insufficient to explain why Coelho's animals failed,
though. Maybe it would, if you also posit a ccache screwup? But it's
not obvious from their configurations that they're using ccache at all.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2019-06-16 17:45:45 Re: pgsql: Rework the pg_statistic_ext catalog
Previous Message Tom Lane 2019-06-16 15:00:27 pgsql: Further fix privileges on pg_statistic_ext[_data].