Re: BUG #13440: unaccent does not remove all diacritics

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Gradek <mike(at)busbud(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13440: unaccent does not remove all diacritics
Date: 2015-06-18 20:30:46
Message-ID: 4348.1434659446@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2015-06-18 15:30:46 -0400, Tom Lane wrote:
>> Yeah, if we do anything other than adding new mappings, I suspect that
>> part could not be back-patched. Maybe adding new mappings shouldn't
>> be back-patched either, though it seems relatively safe to me.

> Hm. Why is it safe to add new mappings? If previously something has been
> indexed with accents because unaccent didn't remove them and you're now
> adding a new mapping to unaccent, the tsearch query will lookup the
> wrong key (with accents removed)?

This is the same situation as any change whatsoever to tsearch
dictionaries. The party line on that is that it usually doesn't
matter much, and if it does you can rebuild your indexes.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2015-06-18 20:32:27 Re: BUG #13440: unaccent does not remove all diacritics
Previous Message Andres Freund 2015-06-18 20:21:35 Re: BUG #13440: unaccent does not remove all diacritics