| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Damir Belyalov <dam(dot)bel07(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, tgl(at)sss(dot)pgh(dot)pa(dot)us, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Danil Anisimow <anisimow(dot)d(at)gmail(dot)com>, Nikita Malakhov <HukuToc(at)gmail(dot)com>, a(dot)lepikhov(at)postgrespro(dot)ru |
| Subject: | Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features) |
| Date: | 2023-03-28 12:16:13 |
| Message-ID: | 43399b33fe573f0548410893f41f84b6@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-03-27 23:28, Damir Belyalov wrote:
> Hi!
>
> I made the specified changes and my patch turned out the same as
> yours. The performance measurements were the same too.
Thanks for your review and measurements.
> The only thing left to do is how not to add IGNORE_DATATYPE_ERRORS as
> a keyword. See how this is done for parameters such as FORCE_NOT_NULL,
> FORCE_NULL, FORCE_QUOTE. They are not in kwlist.h and are not as
> keywords in gram.y.
I might misunderstand something, but I believe the v5 patch uses
copy_generic_opt_list and it does not add IGNORE_DATATYPE_ERRORS as a
keyword.
It modifies neither kwlist.h nor gram.y.
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Damir Belyalov | 2023-03-28 12:22:57 | Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features) |
| Previous Message | Michael Paquier | 2023-03-28 11:42:42 | Re: Non-replayable WAL records through overflows and >MaxAllocSize lengths |