| From: | db(at)zigo(dot)dhs(dot)org |
|---|---|
| To: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: like/ilike improvements |
| Date: | 2007-05-23 05:55:04 |
| Message-ID: | 43311.192.121.104.48.1179899704.squirrel@zigo.dhs.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> And Dennis said:
>
>> It is only when you have a pattern like '%_' when this is a problem
>> and we could detect this and do byte by byte when it's not. Now we
>> check (*p == '\\') || (*p == '_') in each iteration when we scan over
>> characters for '%', and we could do it once and have different loops
>> for the two cases.
>
> That's pretty much what the patch does now - It never tries to match a
> single byte when it sees "_", whether or not preceeded by "%".
My comment was about UTF-8 since I thought we were making a special
version for UTF-8. I don't know what properties other multibyte encodings
have.
/Dennis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | NikhilS | 2007-05-23 06:15:41 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Previous Message | Shachar Shemesh | 2007-05-23 04:19:58 | Re: Re: [Oledb-dev] double precision error with pg linux server, but not with windows pg server |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | NikhilS | 2007-05-23 06:15:41 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Previous Message | Andrew Dunstan | 2007-05-22 22:37:24 | Re: like/ilike improvements |