Re: Naming of new tsvector functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>
Cc: David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Naming of new tsvector functions
Date: 2016-05-04 13:58:22
Message-ID: 4328.1462370302@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> writes:
>> On 03 May 2016, at 00:59, David Fetter <david(at)fetter(dot)org> wrote:
>> I suspect that steering that ship would be a good idea starting with
>> deprecation of the old name in 9.6, etc. hs_filter(), perhaps?

> In 9.5 there already were tsvector functions length(), numnode(), strip()

> Recent commit added setweight(), delete(), unnest(), tsvector_to_array(), array_to_tsvector(), filter().

> Last bunch can be painlessly renamed, for example to ts_setweight, ts_delete, ts_unnest, ts_filter.

> The question is what to do with old ones? Leave them as is? Rename to ts_* and create aliases with deprecation warning?

The other ones are not so problematic because they do not conflict with
SQL keywords. It's only delete() and filter() that scare me.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc Mamin 2016-05-04 13:58:24 9.5.2: "sql" as reserved word?
Previous Message Robert Haas 2016-05-04 13:53:14 Re: pg_dump broken for non-super user