From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, r(dot)zharkov(at)postgrespro(dot)ru, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #16484: pg_regress fails with --outputdir parameter |
Date: | 2020-06-09 08:28:32 |
Message-ID: | 42C77497-417D-4F82-A818-956D8DA5C34D@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
> On 9 Jun 2020, at 07:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> And this leads me to the attached.
FWIW I agree with the extended cleanup you proposed but I also agree that it
doesn't seem worth to backpatch.
> That will create the output directory even if indir doesn't exist, which
> seems likely to lead to bogus directories hanging around in places where
> we don't need them --- plus it seems rather ugly to drop this into the
> middle of the sequence concerned with indir. So shouldn't the new code
> be after the exit for indir not existing?
Makes sense, +1 for moving it after indir processing.
Looking at the diff, I noticed this hunk:
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -571,8 +571,6 @@ sub upgradecheck
my $outputdir = "$tmp_root/regress";
my @EXTRA_REGRESS_OPTS = ("--outputdir=$outputdir");
mkdir "$outputdir" || die $!;
- mkdir "$outputdir/sql" || die $!;
- mkdir "$outputdir/expected" || die $!;
mkdir "$outputdir/testtablespace" || die $!;
On Windows we don't want testtablespace to exist whilst on non-Windows we do.
I wonder if this is a logical copy-paste from test.sh which could be removed as
well?
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-06-09 15:10:20 | Re: BUG #16488: psql installation initdb |
Previous Message | Fabien COELHO | 2020-06-09 07:45:58 | Re: pgbench bug / limitation |