| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: plpgsql raise - parameters can be expressions |
| Date: | 2005-06-13 06:32:58 |
| Message-ID: | 42AD289A.9000703@samurai.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Pavel Stehule wrote:
> I did trivial patch which eliminate limit raise command.
Looks pretty good. Attached is a cleaned-up version that I'll apply to
HEAD tomorrow, barring any objections.
BTW, one regression is that an undefined variable in the RAISE list is
no longer a compile-time error:
create function foo() returns void as '
begin
raise notice ''hello, world: %'', baz;
end;' language plpgsql;
neilc=# select foo();
ERROR: column "baz" does not exist
I don't see an easy way to get around this, though, and it's not too
concerning. Amusingly it does completely break the SQLSTATE and SQLERRM
tests we added a few days ago :)
BTW, another easy improvement in this area is changing the RAISE format
string to allow it to be an expression, rather than only a string literal.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| plpgsql_raise_expr-2.patch | text/x-patch | 11.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2005-06-13 06:37:42 | Re: psql: make \x affect normal queries only |
| Previous Message | Pavel Stehule | 2005-06-13 05:38:39 | Re: plpgsql raise - parameters can be expressions |