Re: pgsql: Use new overflow aware integer operations.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Use new overflow aware integer operations.
Date: 2017-12-22 18:52:54
Message-ID: 4294.1513968774@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-12-22 11:00:54 -0500, Tom Lane wrote:
>> I do not think it is reasonable for these functions to not set the
>> output variable at all in the overflow case; it is not their job
>> to opine on whether the caller may use the result.

> I don't agree. Please note that that the function's documentation
> explicitly says "The content of *result is implementation defined in
> case of overflow.".

I will not accept an implementation that spews compiler warnings
all over the place, which is what this one is doing. Please fix that,
or else I will.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-12-22 23:16:42 Re: pgsql: Use new overflow aware integer operations.
Previous Message Andres Freund 2017-12-22 17:52:25 Re: pgsql: Use new overflow aware integer operations.