Re: Remove Deprecated Exclusive Backup Mode

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: Stephen Frost <sfrost(at)snowman(dot)net>, Christophe Pettus <xof(at)thebuild(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove Deprecated Exclusive Backup Mode
Date: 2019-02-24 21:14:42
Message-ID: 4283f81515659fbf5025163a0649f2974403108a.camel@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost wrote:
> Yes, it *is* impossible to do safe backups with the existing API. There
> is an unquestionable race condition where a system restart will cause
> your system to not come back up without you going in and removing the
> backup_label file- and the only way you make that race window small is
> to remove the backup_label file right after you run pg_start_backup and
> copy it, and then PUT IT BACK at the end before you call pg_stop_backup,
> which is insane, but otherwise the 'race window' is the ENTIRE length of
> the backup.

I just have an idea:

What about an option to keep WAL around for the duration of an exclusive backup?

That way PostgreSQL can still restart after a crash. It will take longer than
expected, but it will work. But then, perhaps the long recovery time is only
marginally better than having to manually delete the backup_label file...

Yours,
Laurenz Albe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christophe Pettus 2019-02-24 21:28:18 Re: Remove Deprecated Exclusive Backup Mode
Previous Message Laurenz Albe 2019-02-24 21:09:40 Re: Remove Deprecated Exclusive Backup Mode