Re: SPI bug.

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tzahi Fadida <tzahi_ml(at)myrealbox(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: SPI bug.
Date: 2005-05-01 11:54:26
Message-ID: 4274C372.7080707@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Neil Conway wrote:
> I think changing SPI_cursor_fetch() and SPI_cursor_move() to take a
> "long" for the "count" parameter is the right fix for HEAD.

Attached is a patch that implements this. A bunch of functions had to be
updated: SPI_execute(), SPI_execute_snapshot(), SPI_exec(), SPI_execp(),
SPI_execute_plan(), SPI_cursor_fetch(), and SPI_cursor_move().

I also updated PL/Python, which was invoking SPI_execute() with an `int'
parameter. PL/Tcl could be updated as well, but it seems the base Tcl
package doesn't provide a Tcl_GetLong() function. PL/Perl could also be
updated (plperl_spi_exec()), but I don't know XS, so I will leave that
to someone else.

Barring any objections, I'll apply this to HEAD tomorrow.

-Neil

Attachment Content-Type Size
spi_count_long-2.patch text/x-patch 18.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message adnandursun 2005-05-01 12:09:37 Re: Feature freeze date for 8.1
Previous Message Sander Steffann 2005-05-01 10:00:08 Re: Feature freeze date for 8.1