Re: [PATCH] check for ctags utility in make_ctags

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Nikolay Shaplov <dhyan(at)nataraj(dot)su>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] check for ctags utility in make_ctags
Date: 2019-01-02 16:35:46
Message-ID: 4273.1546446946@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 01/01/2019 17:44, Nikolay Shaplov wrote:
>> +if [ ! $(command -v ctags) ]
>> +then
>> + echo "'ctags' utility is not found" 1>&2
>> + echo "Please install 'ctags' to run make_ctags" 1>&2
>> + exit 1
>> +fi

> This assumes that the ctags and etags programs are part of packages of
> the same name. I don't think that is always the case.

In fact, that's demonstrably not so: on my RHEL6 and Fedora boxes,
/usr/bin/etags isn't owned by any package, because it's a symlink
managed by the "alternatives" system. It points to /usr/bin/etags.emacs
which is owned by the emacs-common package. So dropping the advice
about how to fix the problem seems like a good plan.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-01-02 17:41:40 Re: BUG #15548: Unaccent does not remove combining diacritical characters
Previous Message Tom Lane 2019-01-02 16:11:39 Re: Query planner / Analyse statistics bad estimate rows=1 with maximum statistics 10000 on PostgreSQL 10.2