Re: psql: Add role's membership options to the \du+ command

From: Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql: Add role's membership options to the \du+ command
Date: 2023-03-10 12:06:04
Message-ID: 42678ca5-f3c6-db1b-e0c5-c63c3ce8997e@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.03.2023 05:31, David G. Johnston wrote:
> Moving the goal posts for this meta-command to >= 9.5 seems like it
> should be done as a separate patch and thread.  The documentation
> presently states we are targeting 9.2 and newer.

I missed the comment at the beginning of the file about version 9.2. I
will return the version check for rolbypassrls.

> My suggestion for the docs is below.

> +        <para>
> +        Shown within each row, in newline-separated format, are the
> memberships granted to
> +        the role.  The presentation includes both the name of the grantor
> +        as well as the membership permissions (in an abbreviated format:
> +        <literal>a</literal> for admin option, <literal>i</literal>
> for inherit option,
> +        <literal>s</literal> for set option.) The word
> <literal>empty</literal> is printed in
> +        the case that none of those permissions are granted.
> +        See the <link
> linkend="sql-grant"><command>GRANT</command></link> command for their
> meaning.
> +        </para>
> +        <para>
> +        If the form <literal>\dg+</literal> is used the comment
> attached to the role is shown.
>          </para>

Thanks. I will replace the description with this one.

> I would suggest tweaking the test output to include regress_du_admin
> and also to make regress_du_admin a CREATEROLE role with LOGIN.

Ok.

Thank you for review. I will definitely work on the new version, but
unfortunately and with a high probability it will happen after March 20.

--
Pavel Luzanov
Postgres Professional:https://postgrespro.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-03-10 12:17:11 Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Previous Message Hayato Kuroda (Fujitsu) 2023-03-10 12:05:52 RE: Time delayed LR (WAS Re: logical replication restrictions)