Re: Change GUC hashtable to use simplehash?

From: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Ants Aasma <ants(dot)aasma(at)cybertec(dot)at>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Gurjeet Singh <gurjeet(at)singh(dot)im>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Change GUC hashtable to use simplehash?
Date: 2025-02-13 02:58:07
Message-ID: 42304488-65ce-4604-854e-2aaf3bc8f09d@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, John!

On 13.02.2025 04:49, John Naylor wrote:
> On Thu, Feb 13, 2025 at 3:42 AM Anton A. Melnikov
> <a(dot)melnikov(at)postgrespro(dot)ru> wrote:

>> On 29.01.2025 10:02, John Naylor wrote:
>>> This is done -- thanks for the report, and for testing.
>>
>> It's good that this is done! But i still see the problem.
>
> Hi, my understanding was you previously tested with the revert. Did
> you not actually test, or are you building differently for these
> cases?

My first test [1] was made at b7493e1
while the second [2] at ecb8226a after reverting in the 235328ee.

The build process was the same in both cases.

Both [1] and [2] contain pg_rightmost_one_pos64() call
that lead to a valgrind error.

Also i did this test very far back at e97b672c88 [3]
and found no errors.

With the best regards,

--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

[1] https://www.postgresql.org/message-id/a3a959f6-14b8-4819-ac04-eaf2aa2e868d%40postgrespro.ru
[2] https://www.postgresql.org/message-id/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec%40postgrespro.ru
[3] https://www.postgresql.org/message-id/4c739718-27d6-44fe-9113-56a251c13275%40postgrespro.ru

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-02-13 03:00:55 Re: Statistics Import and Export
Previous Message Sami Imseih 2025-02-13 02:50:08 Re: [PATCH] Optionally record Plan IDs to track plan changes for a query