Re: postgreSQL-8.0.1 configure --enable-thread-safety with

From: Neil Conway <neilc(at)samurai(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Vikram Kalsi <vikramkalsi(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: postgreSQL-8.0.1 configure --enable-thread-safety with
Date: 2005-03-09 06:06:38
Message-ID: 422E926E.1010103@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> The attached patch should remove the warnings but I am not applying it
> because a non-static/extern global variable should be fine in C code.

What's the harm in applying it? Variables and functions not used outside
the compilation unit in which they are defined _should_ be marked
static; it's not required, but I think it's good style.

-Neil

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vikram Kalsi 2005-03-09 06:24:41 Re: postgreSQL-8.0.1 configure --enable-thread-safety with icc-8.1 on RHEL-AS3 Itanium-2 gives error
Previous Message Tom Lane 2005-03-09 06:00:24 Re: two questions related to tablespace in PG8.0.1