Re: Display Pg buffer cache (WIP)

From: Mark Kirkwood <markir(at)coretech(dot)co(dot)nz>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Display Pg buffer cache (WIP)
Date: 2005-03-08 08:24:49
Message-ID: 422D6151.4040103@coretech.co.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway wrote:
> Mark Kirkwood wrote:

>> + TupleDescInitEntry(tupledesc, (AttrNumber) 5, "relblockbumber",
>> + NUMERICOID, -1, 0);
>
> I think this should be an int4, not numeric.

I was looking for an UINT4OID :-), but numeric seemed the best
compromise (safer than overflowing int4). I guess I could add a type
'blocknumber' that is actually the same as 'oid', but it seems liks a
lot of effort for one column.

cheers

Mark

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2005-03-08 08:25:16 Re: Display Pg buffer cache (WIP)
Previous Message Tom Lane 2005-03-08 07:21:18 Re: Continue transactions after errors in psql