Re: POC, WIP: OR-clause support for indexes

From: Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Finnerty, Jim" <jfinnert(at)amazon(dot)com>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, teodor(at)sigaev(dot)ru, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: 2023-11-10 09:20:57
Message-ID: 421656a9-5df7-41bb-9d58-1c1edbd5dc3e@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06.11.2023 16:51, Alena Rybakina wrote:
> I also support this approach. I have almost finished writing a patch
> that fixes the first problem related to the quadratic complexity of
> processing expressions by adding a hash table.
>
> I also added a check: if the number of groups is equal to the number
> of OR expressions, we assume that no expressions need to be converted
> and interrupt further execution.
>
> Now I am trying to fix the last problem in this patch: three tests
> have indicated a problem related to incorrect conversion. I don't
> think it can be serious, but I haven't figured out where the mistake
> is yet.
>
> I added log like that: ERROR:  unrecognized node type: 0.

I fixed this issue and added some cosmetic refactoring.

The changes are presented in the or_patch_changes.diff file.

--
Regards,
Alena Rybakina
Postgres Professional

Attachment Content-Type Size
or_patch_changes.diff text/x-patch 14.8 KB
v8.2-Replace-OR-clause-to-ANY-expressions.patch text/x-patch 35.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2023-11-10 09:39:27 Re: Bug: RLS policy FOR SELECT is used to check new rows
Previous Message Alexander Lakhin 2023-11-10 09:00:00 Re: ResourceOwner refactoring