Re: [HACKERS] Performance testing of COPY (SELECT) TO

From: Böszörményi Zoltán <zboszor(at)dunaweb(dot)hu>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Performance testing of COPY (SELECT) TO
Date: 2006-08-28 08:58:43
Message-ID: 4213.213.163.11.81.1156755523.squirrel@www.dunaweb.hu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi,

what's the problem with COPY view TO, other than you don't like it? :-)
That was the beginning and is used in production
according to the original authors.

> I also broke the check for a FOR UPDATE clause. Not sure where but it
> must be easy to fix :-) I'd do it myself but I'm heading to bed right
> now.

Fixed.

> I also wanted to check these hunks in your patch, which I didn't like
> very much:
>
> -ERROR: column "a" of relation "test" does not exist
> +ERROR: column "a" does not exist

It was because of too much code sharing. I fixed it by passing
the relation name to CopyGetAttnums() in the relation case,
so the other regression tests aren't bothered now.

The docs and the regression test is modified according to your version.

Best regards,
Zoltán Böszörményi

Attachment Content-Type Size
pgsql-copyselect-10.patch.gz application/x-gzip 11.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2006-08-28 09:08:09 Re: [HACKERS] Trivial patch to double vacuum speed on tables with no indexes
Previous Message Michael Glaesemann 2006-08-28 07:24:20 Re: [HACKERS] Interval aggregate regression failure (expected seems

Browse pgsql-patches by date

  From Date Subject
Next Message Gregory Stark 2006-08-28 09:08:09 Re: [HACKERS] Trivial patch to double vacuum speed on tables with no indexes
Previous Message Michael Glaesemann 2006-08-28 07:24:20 Re: [HACKERS] Interval aggregate regression failure (expected seems