Stats target increase vs compute_tsvector_stats()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Cc: j(dot)urbanski(at)students(dot)mimuw(dot)edu(dot)pl, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Stats target increase vs compute_tsvector_stats()
Date: 2008-12-13 18:02:49
Message-ID: 4207.1229191369@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I started making the changes to increase the default and maximum stats
targets 10X, as I believe was agreed to in this thread:
http://archives.postgresql.org/pgsql-hackers/2008-12/msg00386.php

I came across this bit in ts_typanalyze.c:

/* We want statistic_target * 100 lexemes in the MCELEM array */
num_mcelem = stats->attr->attstattarget * 100;

I wonder whether the multiplier here should be changed? This code is
new for 8.4, so we have zero field experience about what desirable
lexeme counts are; but the prospect of up to a million lexemes in
a pg_statistic entry doesn't seem quite right. I'm tempted to cut the
multiplier to 10 so that the effective range of MCELEM sizes remains
the same as what Jan had in mind when he wrote the code.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2008-12-13 18:05:05 Re: Sync Rep: First Thoughts on Code
Previous Message Robert Haas 2008-12-13 17:22:50 Re: WIP: default values for function parameters