Re: pg_get_viewdef 7.4 et al

Andreas Pflug <Andreas(dot)Pflug(at)web(dot)de> writes:
> here's my proposal for a more economical use of parentheses.

I believe the proposed patch breaks many nontrivial cases (though it's
quite hard to be sure exactly what it does, given a non-contextual diff
:-(). Have you tried running its output back into the system to see
whether the querytree is reconstructed exactly? Don't forget to try
cases where parentheses were used in the original source to force a
non-default evaluation order.

regards, tom lane