Re: Add two missing tests in 035_standby_logical_decoding.pl

Hi,

On 5/5/23 9:11 AM, vignesh C wrote:
> On Fri, 5 May 2023 at 12:34, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
>> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>>
>>> On 5/4/23 6:43 AM, Amit Kapila wrote:
>>>> On Thu, May 4, 2023 at 8:37 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>>>>>
>>>>> Thanks for posting the updated patch, I had run this test in a loop of
>>>>> 100 times to verify that there was no failure because of race
>>>>> conditions. The 100 times execution passed successfully.
>>>>>
>>>>> One suggestion:
>>>>> "wal file" should be changed to "WAL file":
>>>>> +# Request a checkpoint on the standby to trigger the WAL file(s) removal
>>>>> +$node_standby->safe_psql('postgres', 'checkpoint;');
>>>>> +
>>>>> +# Verify that the wal file has not been retained on the standby
>>>>> +my $standby_walfile = $node_standby->data_dir . '/pg_wal/' . $walfile_name;
>>>>>
>>>>
>>>> Thanks for the verification. I have pushed the patch.
>>>>
>>>
>>> It looks like there is still something wrong with this test as there
>>> are a bunch of cfbot errors on this new test (mainly on macOS - Ventura - Meson).
>>>
>>
>> Is it possible for you to point me to those failures?
>
> I think these failures are occuring in CFBOT, once such instance is at:
> https://cirrus-ci.com/task/6642271152504832?logs=test_world#L39
> https://api.cirrus-ci.com/v1/artifact/task/6642271152504832/testrun/build/testrun/recovery/035_standby_logical_decoding/log/regress_log_035_standby_logical_decoding
>

Yeah, thanks, that's one of them.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com