Re: pg_resetwal tests, logging, and docs update

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_resetwal tests, logging, and docs update
Date: 2023-09-13 18:34:42
Message-ID: 41e584af-c378-6020-360d-85e51af3b417@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.09.23 16:36, Aleksander Alekseev wrote:
> ```
> + // FIXME: why 2?
> if (set_oldest_commit_ts_xid < 2 &&
> ```
>
> Should we rewrite this to < FrozenTransactionId ?

That's what I suspect, but we should confirm that.

>
> ```
> +$mult = 32 * $blcksz * 4; # FIXME
> ```
>
> Unless I'm missing something this $mult value is not used. Is it
> really needed here?

The FIXME is that I think a multiplier *should* be applied somehow. See
also the FIXME in the documentation for the -c option.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-09-13 18:34:50 Re: Inefficiency in parallel pg_restore with many tables
Previous Message Nathan Bossart 2023-09-13 17:54:49 Re: Add 'worker_type' to pg_stat_subscription